Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lexer global state management #109

Merged
merged 7 commits into from
Feb 17, 2025
Merged

Lexer global state management #109

merged 7 commits into from
Feb 17, 2025

Conversation

Morikko
Copy link
Contributor

@Morikko Morikko commented Jan 8, 2025

Solve: #108

  1. luqum.thread.parse uses luqum.parser.lexer
  2. Introduce luqum.parser.parse that use the correct lexer automatically
  3. Add documentation

I tried to make the simplest implementation that avoids any breaking change.

alexgarel
alexgarel approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR ! Thanks @Morikko

luqum/thread.py Show resolved Hide resolved
@alexgarel alexgarel mentioned this pull request Feb 7, 2025
Merged
alexgarel
alexgarel reviewed Feb 11, 2025
View reviewed changes
luqum/parser.py Outdated Show resolved Hide resolved
@alexgarel
Copy link
Member

@mmoriniere this is ready !

@mmoriniere mmoriniere merged commit 991e26f into jurismarches:master Feb 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Morikko @alexgarel @mmoriniere